docusaurus
docusaurus copied to clipboard
fix: algolia mobile search modal responsiveness
Pre-flight checklist
- [x] I have read the Contributing Guidelines on pull requests.
- [ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
- [ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.
Motivation
Fixes Algolia mobile search modal responsiveness issue.
Test Plan
Test links
Loom preview: https://www.loom.com/share/1adeb5c8ff714965b0136bb94ded58ed
Related issues/PRs
Fixes #7831
[V2]
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 303035b42afb6ae7da78b21034b52e1ecafee3a8 |
Latest deploy log | https://app.netlify.com/sites/docusaurus-2/deploys/62f2408b57b9a50009699fb1 |
Deploy Preview | https://deploy-preview-7930--docusaurus-2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
⚡️ Lighthouse report for the deploy preview of this PR
URL | Performance | Accessibility | Best Practices | SEO | PWA | Report |
---|---|---|---|---|---|---|
/ | 🟠 84 | 🟢 98 | 🟢 100 | 🟢 100 | 🟠 80 | Report |
/docs/installation | 🟢 90 | 🟢 100 | 🟢 100 | 🟢 100 | 🟢 90 | Report |
@shortcuts any opinion on this?
Should it be changed directly in the DocSearch package? Looks likeyou switch from fixed (desktop) to absolute (mobile), and maybe there's a good reason for that?
For some reason, I am able to reproduce this edge case only if I resize my browser window, but it doesn't show the problem when resizing using the devtools 🤷♂️
@shortcuts any opinion on this?
Should it be changed directly in the DocSearch package? Looks likeyou switch from fixed (desktop) to absolute (mobile), and maybe there's a good reason for that?
Indeed I believe this should be fixed at the DocSearch level, I can reproduce on a simple sandbox: https://duc7s6.csb.app/
I don't have the details of the absolute choice, maybe @shipow knows
@shortcuts @slorber Let me know what changes I need to do. Thanks!
Okay @slorber Np. I'll pick up another issue and will work upon it. Thanks!