docusaurus
docusaurus copied to clipboard
facebook
fix(theme-classic): fix announcement bar height cutting off text
Pre-flight checklist
- [X] I have read the Contributing Guidelines on pull requests.
- [X] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
- [X] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.
Motivation
Closes #7815
Test links
Deploy preview: https://deploy-preview-7820--docusaurus-2.netlify.app/
Related issues/PRs
Related PR: #5430
Hi @andrewsemchism!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
[V2]
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | f9aa4d09bef0b1770daa5f8f9542acd8070befcf |
| Latest deploy log | https://app.netlify.com/sites/docusaurus-2/deploys/62dafc730a0be70008f86e88 |
| Deploy Preview | https://deploy-preview-7820--docusaurus-2.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚡️ Lighthouse report for the deploy preview of this PR
| URL | Performance | Accessibility | Best Practices | SEO | PWA | Report |
|---|---|---|---|---|---|---|
| / | 🟠 79 | 🟢 100 | 🟢 100 | 🟢 100 | 🟢 90 | Report |
| /docs/installation | 🟠 82 | 🟢 100 | 🟢 100 | 🟢 100 | 🟢 90 | Report |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thanks for pointing that out. I will try to find a solution. I noticed that issue still occurs sometimes regardless of the change I made. If you visit the docs page, scroll down just a few pixels in the main content, you will see the same problem.
No good solution provided yet
Will close this PR because this solution is not good enough
The most promising one will probably be this one but it doesn't work yet: https://github.com/facebook/docusaurus/pull/8493