docusaurus
docusaurus copied to clipboard
fix(npm2yarn): use forked npm-to-yarn; fix a few conversion bugs
Motivation
I decided to fork npm-to-yarn package and add support for missing commands,
yarn create name->npm init nameandyarn init name->npm create namenpm run x -- --args->yarn x --argsoryarn run x --argsnpm ls abc bcd->yarn list --pattern "abc|bcd"npm test/start/stop->yarn test/start/stop
see:
- https://typescript-eslint.io/docs/linting/troubleshooting#how-do-i-check-to-see-what-versions-are-installed
- https://www.electronjs.org/docs/latest/tutorial/quick-start#create-your-application
fixes #5861
Note
There is pr for original package at https://github.com/nebrelbug/npm-to-yarn/pull/22
i did more small fixes at https://github.com/armano2/npm-to-yarn/commits/main, mainly https://github.com/armano2/npm-to-yarn/commit/2b9198390fec46dcb56c9c8f92ac5f81358d5437
Test plans
https://deploy-preview-6005--docusaurus-2.netlify.app/docs/next/i18n/tutorial https://deploy-preview-6005--docusaurus-2.netlify.app/docs/i18n/crowdin https://deploy-preview-6005--docusaurus-2.netlify.app/docs/i18n/git/#initialize-the-i18n-folder
[V2]
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 342e043cd3a34714b4998c7bb1cc68b30627906b |
| Latest deploy log | https://app.netlify.com/sites/docusaurus-2/deploys/6276d21cf49edf00088e1180 |
| Deploy Preview | https://deploy-preview-6005--docusaurus-2.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
β‘οΈ Lighthouse report for the deploy preview of this PR
| URL | Performance | Accessibility | Best Practices | SEO | PWA | Report |
|---|---|---|---|---|---|---|
| / | π΄ 38 | π’ 100 | π’ 100 | π’ 100 | π’ 90 | Report |
| /docs/installation | π 83 | π’ 99 | π’ 100 | π’ 100 | π’ 90 | Report |
do we have any updates?
@armano2 Could you rebase first? We are in a pretty awkward situation right now because the @docusaurus organization is there but neither @slorber nor I have member access to it. Maybe we need to wait a bit more. No idea what FB politics is going on, but accepting forked code into our repo is very complicated as well (unlike two years ago).
I don't forget, but waiting for @zpao to give me member access.
Will figure out if we should take temporary actions immediately (ie use a fork) until the org is set up properly
Is this something that we could just rewrite internally rather than forking externally?
If @armano2 has ideas for how the package can be rewritten entirely - it would save having to go through any hoops at all and could just be integrated into the plugin directly.
I don't know what's all the business around it, but I think we basically can't do anything meaningful about itπ
- We can't copy the code to our own repo (although we used to do that a lot)
- We can fork the package under @slorber's account but he'd rather not at this stage
@bradzacher If TS-ESLint is open to forking the npm2yarn remark plugin, I can help facilitate that.
@armano2 Could you rebase first?
rebased
Thanks @armano2 Sorry for stalling this PR longer than it should haveπ Not in my will
suppressed by #8650