docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

fix(eslint-plugin): specify exact type of `no-untranslated-text` rule options

Open andreww2012 opened this issue 3 weeks ago • 3 comments

Pre-flight checklist

  • [x] I have read the Contributing Guidelines on pull requests.
  • [ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • [ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

no-untranslated-text ESLint rule's ignoredStrings option currently allows elements of any type. This makes it easier for typos/errors in rule options to go unnoticed. This PR strengthens the rule's options schema.

Test Plan

N/A

Related issues/PRs

N/A

andreww2012 avatar Nov 30 '25 19:11 andreww2012

Hi @andreww2012!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

meta-cla[bot] avatar Nov 30 '25 19:11 meta-cla[bot]

[V2]

Built without sensitive environment variables

Name Link
Latest commit ba48c32acc62792539ad36c252c844e053ff7fc7
Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/692c97c9fbb64100085fe445
Deploy Preview https://deploy-preview-11587--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 30 '25 19:11 netlify[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

meta-cla[bot] avatar Nov 30 '25 20:11 meta-cla[bot]

thanks 👍

slorber avatar Dec 05 '25 18:12 slorber