docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

feat(cli): add `docusaurus serve --no-clean-urls` option

Open ZumiFlores opened this issue 1 year ago • 4 comments

This PR adds the ability to configure the cleanUrls option for the serve command, as described in issue #7991. It allows users to toggle clean URLs during local development.

Pre-flight checklist

  • [x] I have read the Contributing Guidelines on pull requests.
  • [x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • [x] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-10552--docusaurus-2.netlify.app/

Related issues/PRs

Fix https://github.com/facebook/docusaurus/issues/7991

ZumiFlores avatar Oct 03 '24 20:10 ZumiFlores

Hi @ZumiFlores!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 03 '24 20:10 facebook-github-bot

[V2]

Built without sensitive environment variables

Name Link
Latest commit 99208cbc3cfcecdfe15b244a39973e6368c3d115
Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66fefecf14984c0008d029d5
Deploy Preview https://deploy-preview-10552--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 03 '24 20:10 netlify[bot]

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 58 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🔴 48 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 61 🟢 96 🟢 96 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 96 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

github-actions[bot] avatar Oct 03 '24 20:10 github-actions[bot]

Thanks

Can you please sign the CLA? I can't merge any PR without this.

slorber avatar Oct 09 '24 07:10 slorber