docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

Update command to check crowdin cli version

Open MarryamZulfiqar opened this issue 1 year ago • 4 comments

npm run crowdin -- --version

the above doesnt work on windows, the following does

npm run crowdin --version

Pre-flight checklist

  • [x] I have read the Contributing Guidelines on pull requests.
  • [x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • [x] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

MarryamZulfiqar avatar Oct 01 '24 07:10 MarryamZulfiqar

Hi @MarryamZulfiqar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 01 '24 07:10 facebook-github-bot

[V2]

Built without sensitive environment variables

Name Link
Latest commit 97520d34f6f67fdc06fc54a84d02e93374480a84
Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66fb9efdf6cdbf0008f4116a
Deploy Preview https://deploy-preview-10540--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 01 '24 07:10 netlify[bot]

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 56 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 51 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

github-actions[bot] avatar Oct 01 '24 07:10 github-actions[bot]

Which version of NPM are you using and what does it mean "does not work". How do you see that it doesn't work?

We have npm run thing -- --extraArg in multiple places of our docs. I suspect you are using an old version of Docusaurus/npm. Please share exact version numbers and the error message you get.

Also I can't merge any PR if you don't sign the CLA.

slorber avatar Oct 01 '24 07:10 slorber

I figured it out: it doesn't work only on npm if you forget to add a crowdin script in package.json:

CleanShot 2024-10-31 at 11 54 22

We document to do this, so I'm going to close assuming you forgot this step.

Note: npm run crowdin --version is never the good command, with/without the crowdin script it gives you the version of npm, not the version of crowdin.

slorber avatar Oct 31 '24 10:10 slorber