docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

chore: bump typescript-eslint to v7

Open JoshuaKGoldberg opened this issue 1 year ago โ€ข 5 comments

Pre-flight checklist

  • [x] I have read the Contributing Guidelines on pull requests.
  • ~[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.~
  • ~[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.~

Motivation

๐Ÿ‘‹ Hi! I'm coming over from https://github.com/typescript-eslint/typescript-eslint/issues/9141: I'd like to try out the new typescript-eslint v8 version in beta now... but Docusaurus is still on v5. This PR gets you to the latest stable version, v7, without making any other substantial changes.

Test Plan

yarn lint
yarn build

Test links

n/a - should be no functional code changes.

Related issues/PRs

None exist, but if you'd like I'm happy to file any issues you'd want! โค๏ธ

JoshuaKGoldberg avatar Jul 05 '24 18:07 JoshuaKGoldberg

[V2]

Built without sensitive environment variables

Name Link
Latest commit 14307003d16a7784b0724b3ee5efb6483cf0d00f
Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66888e23d56a830008b1756c
Deploy Preview https://deploy-preview-10271--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 05 '24 18:07 netlify[bot]

โšก๏ธ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ ๐ŸŸ  79 ๐ŸŸข 98 ๐ŸŸข 96 ๐ŸŸข 100 Report
/docs/installation ๐ŸŸ  56 ๐ŸŸข 97 ๐ŸŸข 100 ๐ŸŸข 100 Report
/docs/category/getting-started ๐ŸŸ  75 ๐ŸŸข 100 ๐ŸŸข 100 ๐ŸŸ  86 Report
/blog ๐ŸŸ  70 ๐ŸŸข 100 ๐ŸŸข 100 ๐ŸŸ  86 Report
/blog/preparing-your-site-for-docusaurus-v3 ๐Ÿ”ด 49 ๐ŸŸข 96 ๐ŸŸข 100 ๐ŸŸข 100 Report
/blog/tags/release ๐ŸŸ  70 ๐ŸŸข 100 ๐ŸŸข 100 ๐ŸŸ  86 Report
/blog/tags ๐ŸŸ  75 ๐ŸŸข 100 ๐ŸŸข 100 ๐ŸŸ  86 Report

github-actions[bot] avatar Jul 05 '24 18:07 github-actions[bot]

Failing because tests run on Node 18, not Node 18.18. I asked in Discord: https://discord.com/channels/398180168688074762/584803742801723424/1258853596338847825

JoshuaKGoldberg avatar Jul 05 '24 18:07 JoshuaKGoldberg

Thanks

Failing because tests run on Node 18, not Node 18.18. I asked in Discord: discord.com/channels/398180168688074762/584803742801723424/1258853596338847825

Is this the only blocker to this PR?

We still support Node 18.0, but we'll very likely upgrade to Node 20 in the next major

slorber avatar Jul 09 '24 14:07 slorber

New and removed dependencies detected. Learn more about Socket for GitHub โ†—๏ธŽ

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem +5 230 kB ljharb
npm/[email protected] None 0 32.1 kB feross
npm/[email protected] environment Transitive: eval, unsafe +5 1.31 MB evilebottnawi
npm/[email protected] None 0 95.4 kB npm-cli-ops
npm/[email protected] None +1 23.3 kB redonkulus
npm/[email protected] None 0 45 kB ljharb
npm/[email protected] None 0 140 kB 7rulnik
npm/[email protected] None +3 123 kB sindresorhus
npm/[email protected] filesystem Transitive: unsafe +9 5.95 MB sethiii
npm/[email protected] None 0 46.9 kB sokra
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +8 7.37 MB evilebottnawi
npm/[email protected] environment, eval Transitive: filesystem, shell +7 3.42 MB fabiosantoscode
npm/[email protected] None 0 84 kB typescript-bot
npm/[email protected] None 0 202 kB sindresorhus
npm/[email protected] None 0 40.6 MB typescript-bot
npm/[email protected] None +3 180 kB wooorm
npm/[email protected] None 0 4.31 kB dougwilson
npm/[email protected] None +1 493 kB garycourt
npm/[email protected] None 0 5.48 kB tootallnate
npm/[email protected] None +2 110 kB wooorm
npm/[email protected] None +5 67.5 kB sindresorhus

๐Ÿšฎ Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full reportโ†—๏ธŽ

socket-security[bot] avatar Jul 16 '24 16:07 socket-security[bot]