create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

Add support for pnpm package manager

Open macjabeth opened this issue 6 years ago • 19 comments
trafficstars

Hello! I was researching if CRA had any support for the pnpm package manager. I came across issue #2809 and - per the last comment - decided to try and tackle this implementation myself.

This is my initial pull request, and I know it still needs some work because I tested it myself and after there are some issues still. I'm hoping by creating this PR, it'll get a discussion going on how to properly implement this.

Thank you for considering this feature!

macjabeth avatar Oct 07 '19 05:10 macjabeth

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 07 '19 05:10 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Oct 07 '19 05:10 facebook-github-bot

Hi @macjabeth, thanks for spending the time on this. In future, I'd recommend that you raise an issue first just to ensure this work isn't being tackled by someone else - we don't ever want people to waste time...

We're about to roll out a new feature in the coming weeks, and this PR would conflict with that... if you're OK with it, could we fix conflicts and merge this in after PR that is merged?

mrmckeb avatar Oct 09 '19 07:10 mrmckeb

@mrmckeb Of course! Sorry for not raising an issue first... Would be happy waiting until then and resolving any conflicts.

macjabeth avatar Oct 09 '19 10:10 macjabeth

If you can subscribe to #7716, we can resume this PR as soon as that's merged. I hope next week, as I'll spend Monday finishing it off.

mrmckeb avatar Oct 10 '19 06:10 mrmckeb

Would love to see this improvement to make it to the master ;)

arzga avatar Mar 11 '20 07:03 arzga

Is there anything I can do to help get this added?

ZachHaber avatar Apr 14 '20 03:04 ZachHaber

@ZachHaber Is there anything I can do to help get this added?

I guess we'd better re-apply changes made by @macjabeth based on the current master branch?

In the meantime, I created a script in my PATH named npm, which call pnpm $@ ...

beenotung avatar Jul 02 '20 22:07 beenotung

Is there any progress and chances to merge it?

alex-shamshurin avatar Aug 15 '20 13:08 alex-shamshurin

Any update on this?

adelarsq avatar Sep 23 '20 19:09 adelarsq

Is there any update on this? I would very much like this feature to be in CRA ...

nyn3x avatar Feb 04 '21 06:02 nyn3x

Any news on this?

DylanCulfogienis avatar May 10 '21 19:05 DylanCulfogienis

For folks still waiting for pnpm support from create-react-app, I made an alternative npm init script that can work with any package managers. git npm

beenotung avatar May 21 '21 15:05 beenotung

Hope it gets implemented soon

ashishbinu avatar Aug 30 '21 16:08 ashishbinu

Hey!! Facebook!! Could you?!? Hum. hum??

ruifortes avatar Sep 29 '21 21:09 ruifortes

Any update on this?

Philzen avatar Feb 02 '22 22:02 Philzen

For those who want to go down with the ship (create-react-app is going away, try googling if you don't know what I mean), here's a version that you can use which uses pnpm internally:

pnpm create @upleveled/react-app my-app

karlhorky avatar Apr 14 '23 16:04 karlhorky

If you just want to create a typescript react app, instead of a generic creator with multiple template options. You can run:

npm init react-ts-template

Or

npx create-react-ts-template

It will create the project for you (without installing the dependencies)

You can then cd into the project directory and install with any package manager, e.g.

cd my-app
pnpm i

beenotung avatar Apr 15 '23 16:04 beenotung

Hello @macjabeth This Pull Request has been open for 3 years. Any update on this?

CoolPlayLin avatar Jan 01 '24 03:01 CoolPlayLin