create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

Add tests for extending ESLint

Open ianschmitz opened this issue 5 years ago • 12 comments

This is a good first PR!

We should add some tests to cover #7036. They should cover both JavaScript and TypeScript support.

They can probably be added to test/fixtures.

ianschmitz avatar Aug 13 '19 04:08 ianschmitz

@ianschmitz I'll take a look at this if no one else is currently looking.

dscanlan avatar Aug 13 '19 10:08 dscanlan

@dscanlan it's all yours!

iansu avatar Aug 13 '19 16:08 iansu

I would love to take this issue if you are not working on it. @dscanlan

kartik-budhiraja avatar Sep 15 '19 06:09 kartik-budhiraja

Sure, @kartik-budhiraja . Sorry i've not got round to this..

dscanlan avatar Sep 16 '19 11:09 dscanlan

I would love to work on it @ianschmitz

kushthedude avatar Sep 18 '19 06:09 kushthedude

@kartik-budhiraja you want to work on this? Giver! If not @kushthedude can take it.

ianschmitz avatar Sep 19 '19 00:09 ianschmitz

@ianschmitz I will work over it. Thanks!

kartik-budhiraja avatar Sep 19 '19 01:09 kartik-budhiraja

@ianschmitz I created a PR #7816, it covers tests for javascript. For typescript, all typescript tests suits fail with this error: Failed to load parser '@typescript-eslint/parser declared in 'BaseConfig >> /Users/......./create-react-app/packages/eslint-config-react-app/index.js#overrides[0]': Cannot find module 'typescript' Can you please help me out here?

kartik-budhiraja avatar Oct 13 '19 05:10 kartik-budhiraja

Hi everyone, what is the status on this issue? I would love to continue working at the existing PR if no one is looking at it right now.

danangan avatar Jul 08 '20 20:07 danangan

Hey @danangan, feel free to take over the PR if you want, I am still stuck at the same issue. If you can get it solved, go for it!!

kartik-budhiraja avatar Jul 08 '20 21:07 kartik-budhiraja

I've left a comment on #7816. I had a play with it and found the problem.

sheepsteak avatar Aug 22 '20 13:08 sheepsteak

is this still relevant?

droidMakk avatar Oct 05 '22 08:10 droidMakk

Hey is the issue up for grabs?

0xSaksham avatar Jul 31 '23 12:07 0xSaksham

Hey can I still work on this issue?

Aayushp2002 avatar Jan 04 '24 22:01 Aayushp2002