create-react-app
create-react-app copied to clipboard
Add tests for extending ESLint
This is a good first PR!
We should add some tests to cover #7036. They should cover both JavaScript and TypeScript support.
They can probably be added to test/fixtures
.
@ianschmitz I'll take a look at this if no one else is currently looking.
@dscanlan it's all yours!
I would love to take this issue if you are not working on it. @dscanlan
Sure, @kartik-budhiraja . Sorry i've not got round to this..
I would love to work on it @ianschmitz
@kartik-budhiraja you want to work on this? Giver! If not @kushthedude can take it.
@ianschmitz I will work over it. Thanks!
@ianschmitz I created a PR #7816, it covers tests for javascript.
For typescript, all typescript tests suits fail with this error:
Failed to load parser '@typescript-eslint/parser declared in 'BaseConfig >> /Users/......./create-react-app/packages/eslint-config-react-app/index.js#overrides[0]': Cannot find module 'typescript'
Can you please help me out here?
Hi everyone, what is the status on this issue? I would love to continue working at the existing PR if no one is looking at it right now.
Hey @danangan, feel free to take over the PR if you want, I am still stuck at the same issue. If you can get it solved, go for it!!
I've left a comment on #7816. I had a play with it and found the problem.
is this still relevant?
Hey is the issue up for grabs?
Hey can I still work on this issue?