create-react-app
create-react-app copied to clipboard
facebook
Add Jest configuration for snapshotresolver
As I understand, right now CRA only supports a handful of Jest configuration overrides, either by adding them to package.json or adding a jest.config.js to your project.
First question would be, why are you not allowing to just add a jest.config.js and read all of the configuration variables that Jest provides usually, why add just a few of them?
And the more important suggestion, can you add snapshotresolver to this list of allowed customizations? https://jestjs.io/docs/en/configuration#snapshotresolver-string
It has been added with Jest 24 and would really help clean up the codebase a bit, since I don't think it's necessary to have generated code right next to my .tsx, .scss and .test.ts files.. If not, could you at least explain, how the decision was made to not just check for a jest.config.js and then give it to the test runner, so the dev can decide what they want to override or not.
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Was about to open this issue, but was happy to find it here already! Similar to #3116, this could be a pretty simple fix.
I just checked the source code and this shouldn't be hard to implement. I will try to put together a pull request for this, should be a no brainer.
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
Bumping to avoid staleness; still very much looking forward to a solution!
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
Hopefully I did everything right, this is my first PR into any large repository.
Is there any opposition from the CRA team to allowing all options specified in a jest.config.js file to be used and override the defaults? I don't see the harm.
Is there any work around for getting this to work with CRA (without the PR)?
It seems like the PR has been tagged as an enhancement :( It'll be so soon
I was going to do the same PR until I stumbled on this, it really should be merged, a nice feature to add, and a well-needed one to make folders structure neater.
