facebook
test: enhance CRA test suite with additional edge cases and validations
Summary
This PR enhances the test suite for create-react-app with additional test cases and improvements to make the suite more robust and developer-friendly.
✅ What's Added:
-
Invalid template check (
--template unknown-template) -
Invalid project name check (
123invalid) -
TypeScript-specific file check (
tsconfig.json) -
ESLint configuration presence (check for
.eslintrc.jsonor.eslintrc.js) - Snapshot testing for stdout output
-
Cleaner file comparison using
Set - Better logging before test cleanup
✅ Motivation
These changes aim to:
- Catch more edge cases early
- Make test failures easier to debug
- Improve confidence in behavior for community users
Let me know if further enhancements are needed. 🚀
Hi @tejhande!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hi team! Just checking in to see if there’s anything I can improve or clarify in this PR. Happy to make updates if needed. Thanks!