create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

fix(babel-preset-react-app): specify minor version for `core-js`

Open jluxenberg opened this issue 1 year ago • 3 comments

(Closes https://github.com/facebook/create-react-app/issues/13280)

babel-preset-react-app will use the most recent version of core-js, but previously @babel/preset-env was configured with corejs param set to the number "3". According to the @babel/preset-env docs:

[The corejs option] ensures @babel/preset-env injects the polyfills supported by your core-js version. It is recommended to specify the minor version otherwise "3" will be interpreted as "3.0" which may not include polyfills for the latest features. https://babeljs.io/docs/babel-preset-env#corejs

babel-preset-react-app should instead specify a minor version e.g. "3.31", and be periodically updated, so that new core-js polyfills are included.

jluxenberg avatar Jul 10 '23 19:07 jluxenberg

Hi @jluxenberg!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 10 '23 19:07 facebook-github-bot

@zpao Any chance of getting this merged? Let me know if there's anything you need from me.

jluxenberg avatar Sep 21 '23 19:09 jluxenberg

I was hoping this pr would finally be merged @zpao

maxisusi avatar Apr 04 '24 08:04 maxisusi