create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

fix(webpackDevServer): fix deprecation warning

Open zhaomengfan opened this issue 2 years ago • 23 comments

update webpack-dev-server + fix deprecation warning (#11860)

zhaomengfan avatar Dec 31 '21 08:12 zhaomengfan

Hi @zhaomengfan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 31 '21 08:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Dec 31 '21 09:12 facebook-github-bot

@raix , could this be added to 5.0.1, by any chance? It would reduce CRA verbosity on startup.

yann-combarnous avatar Jan 07 '22 16:01 yann-combarnous

@zhaomengfan Recommend upgrading webpack-dev-server to 4.7.3 to include a recent security patch

wcedmisten-reify avatar Jan 11 '22 17:01 wcedmisten-reify

Will this deprecation be fixed in a future release?

ramdaniAli avatar Jan 15 '22 16:01 ramdaniAli

Would love to see this implemented to reduce developer confusion.

brookjordan avatar Mar 07 '22 06:03 brookjordan

Is there a workaround until this PR is merged?

Or else, is there anything that can help with it? I assume external user review / approval will not count.

Meligy avatar Apr 26 '22 00:04 Meligy

bump

icey-franken avatar May 13 '22 23:05 icey-franken

This is actually breaking our app locally. With react-scripts 5.0.1, when we run npm start, despite it just being a warning it stops the dev server with the deprecation warning. Is there any way to fix this while we wait for 5.0.2?

sbaggott avatar May 17 '22 19:05 sbaggott

It work. The warning it's gone.

It really does the trick.

pat-ryb avatar May 23 '22 18:05 pat-ryb

At the moment my app won't start up using [email protected]. I see a lot of failing tests in the requested Review? How do we get this reviewed/fixed/merged in?

dirkesquire avatar Jun 16 '22 14:06 dirkesquire

Is this planned for 5.0.2?

Meligy avatar Aug 06 '22 08:08 Meligy

bump. image

ithrforu avatar Nov 09 '22 21:11 ithrforu

The issue got fixed with the changes in the below link https://github.com/facebook/create-react-app/pull/11862/files/2dff88610f9ad215349424d1769b88e0a0d2fa1d Thank you..!

akhileshgoud2504 avatar Nov 16 '22 20:11 akhileshgoud2504

Is this still planned for 5.0.2 patch ?

micktdj avatar Dec 26 '22 23:12 micktdj

  • Is there anybody sponsoring or working on this PR? It fails 7 out of 9 tests.

  • The issue https://github.com/facebook/create-react-app/issues/11860 is still open.

MikeMcC399 avatar Jan 10 '23 18:01 MikeMcC399

I can't see the failure reason anymore as Azure dropped the run results, does anyone know why the tests are failing?

BalaM314 avatar Apr 28 '23 13:04 BalaM314

@BalaM314

The whole PR is now stale, so either the original submitter @zhaomengfan would need to rebase or somebody else would need to be active. Considering that the last commit to the master branch was in September 2022 it seems that the repository is no longer being actively maintained.

  • Edit: See also issue https://github.com/facebook/create-react-app/issues/13393

MikeMcC399 avatar Apr 28 '23 14:04 MikeMcC399

how can I use this branch on my code?

Abel13 avatar Jul 20 '23 16:07 Abel13

@nathanwiles Your school project's recommendation is outdated. Take a look at e.g. vite. create-react-app is unmaintained.

morremeyer avatar Nov 19 '23 21:11 morremeyer

IMO CRA should be maintained. Lots and lots of production apps still use CRA. This isn't breaking my app, but I do see a warning pop up for a split second before the local server runs. It's wild that this PR is still open, how can we merge it in? @zhaomengfan please merge this

misraelson avatar Dec 20 '23 17:12 misraelson

Hi Guys, Will this be fixed in any new releases?

jaypatel22222 avatar May 16 '24 07:05 jaypatel22222

@jaypatel22222

Hi Guys, Will this be fixed in any new releases?

  • You should probably read https://github.com/facebook/create-react-app/issues/13393 for background information. It sounds highly unlikely that there will be any new release.

MikeMcC399 avatar May 16 '24 08:05 MikeMcC399