create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

Dev Server does not always show typescript compilation errors

Open jdgreenberger opened this issue 3 years ago • 5 comments

Describe the bug

React dev server does not consistently display typescript errors. Frequently, when running react-scripts start, the compiler does not display typescript errors and I only see them when running react-scripts build. I have noticed that this happens more frequently when there is a typescript error in files that have not been modified or when the dev server is consuming more CPU. Any ideas on why this happens and how to address it?

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

"typescript errors" "typescript changes"

Environment

current version of create-react-app: 3.4.1

System: OS: macOS 11.2.1 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Binaries: Node: 12.7.0 - /usr/local/bin/node Yarn: 1.22.10 - /usr/local/bin/yarn npm: 6.10.0 - /usr/local/bin/npm Browsers: Chrome: 89.0.4389.128 Firefox: 85.0.2 Safari: 14.0.3 npmPackages: react: 16.10 => 16.10.2 react-dom: 16.8.6 => 16.8.6 react-scripts: ^4.0.3 => 4.0.3 npmGlobalPackages: create-react-app: Not Found

Steps to reproduce

  1. Create a CRA typescript project of sufficient size (couple hundred files)
  2. Run dev server
  3. Trigger an error in a file you didn't change

Expected behavior

Errors show up in the console

Actual behavior

Compiles without error

Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

jdgreenberger avatar Apr 19 '21 22:04 jdgreenberger

Update: on the latest version I can't get any typescript errors to show up. My .env is

FAST_REFRESH=false
ESLINT_NO_DEV_ERRORS=true
TSC_WATCHFILE=UseFsEventsWithFallbackDynamicPolling

jdgreenberger avatar Apr 20 '21 15:04 jdgreenberger

Any update on this?

jdgreenberger avatar Jun 29 '21 17:06 jdgreenberger

@jdgreenberger I had a similar symptom and fixed it by upgrading my typescript devDependency from ^3.9.0 to ^4.0.2. I was getting the expected eslint warnings / errors all along, but not the errors from tsc. This was on an existing project which had been migrated from CRA 3 to 4. After upgrading to TypeScript 4.x I started getting expected tsc compilation errors from react-scripts start.

nj314 avatar Sep 16 '21 18:09 nj314

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

stale[bot] avatar Jan 09 '22 14:01 stale[bot]

I got this too going from react-scripts 3.4.1 to 4.0.3 and https://github.com/facebook/create-react-app/issues/10852#issuecomment-921120083 fixed it.

I was about to open another issue to bump peerDependency, but I see that happened in #9964, albeit to:

https://github.com/facebook/create-react-app/blob/228528c3e768555db5c8e8b5cb04db9c5aae9fed/packages/react-scripts/package.json#L96-L98

I'm going to ask over there why ^3.2.1 || 🤔

davetapley avatar Jul 21 '22 19:07 davetapley

With typescript 5.1.3 as an override, I'm having a similar issue.

I am no longer presented with a typescript error (with npm start) when I have function Component(props: Props) { console.log(notprops) }. It does show the error in my IDE, though.

rostero1 avatar Jul 07 '23 13:07 rostero1