componentkit icon indicating copy to clipboard operation
componentkit copied to clipboard

Published 20 hours ago • verified publisher icon facebook

CKTextComponent and links again

Open RomanTruba opened this issue 8 years ago • 5 comments

Hi guys. #246 , #253 says it is possible to get link pressed by almost hacking: accessing CKTextComponentView renderer and then getting link from it. But the fact is CKTextComponentView.h now project-level header, and now it is impossible to access it from my code. Maybe it is time now to implement the feature "Which link was exactly pressed"?

RomanTruba avatar Feb 15 '17 23:02 RomanTruba

Sure, we're open to pull requests!

ocrickard avatar Feb 17 '17 15:02 ocrickard

I think a really nice PR here would be to provide a CKTypedComponentAction form of touch up action.

ocrickard avatar Feb 20 '17 14:02 ocrickard

@nscoding what do you think of open sourcing the internal text component? I'm tired of maintaining two stacks.

ocrickard avatar Feb 22 '17 23:02 ocrickard

Hello, any updates here? How to detect tapped link?

serjiogunit avatar Jun 20 '19 15:06 serjiogunit

Sorry for this being around for a while. We have recently discussed this again with the team and we decided to not add new features to the CKTextComponentView as it is right now but rather work on releasing a new text component that we have built internally. As soon we have a rough ETA we will update this issue.

fabiomassimo avatar Jun 21 '19 14:06 fabiomassimo