chef-cookbooks icon indicating copy to clipboard operation
chef-cookbooks copied to clipboard

fb_network_scripts changes should be reflected in /var/chef/backup

Open davide125 opened this issue 3 years ago • 1 comments

fb_network_scripts does some trickery under the hood to in-place modify configs to try and avoid network restarts at much as possible. This is great, but the changes don't get reflected in /var/chef/backups, making troubleshooting harder at times. I'm not entirely sure if this is something we can sanely improve, but filing this for tracking and visibility.

davide125 avatar Oct 08 '20 16:10 davide125

There's some ways to make this better.

That said I'd be careful... there are two different times when we write to that file - one is to mask "cosmetic" changes - the other is because we are going to implement the change ourselves and don't want to trigger a full interface bounce. It may make sense to only "backup" the latter.

jaymzh avatar Oct 08 '20 16:10 jaymzh