facebook
[buck2] Add find_missing cache to oss re client
We are trying to avoid calling too many find_missing for duplicated digests when uploading. This feature originally should enabled on cas daemon but seems missing on oss version. We are seeing 2-4x improvement on the longest re_upload time and aggregated uploading time.
Hi @miaoyipu!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@JakobDegen the new revision addressed your comments. I don't have the merge permission. If you feels the PR is good to go, could you help me to merge the PR? Thanks
@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.