buck2 icon indicating copy to clipboard operation
buck2 copied to clipboard

Allow uppercase hashes

Open lukts30 opened this issue 2 years ago • 1 comments

Buck2 http_archive and other rules currently reject uppercase hashes like these provided by Microsoft.

As a user I should not need to manually lowercase them.

Internal error: Invalid sha256 digest. Expected 83B19309FFCA499D739249C1FD3F89333B44792C1B9B338149B9C37BD2547196, got 83b19309ffca499d739249c1fd3f89333b44792c1b9b338149b9c37bd2547196. URL: https://aka.ms/windev_VM_hyperv

lukts30 avatar Nov 11 '23 14:11 lukts30

Makes sense - I've written such a diff internally and will send it open source on Tuesday after the holiday.

ndmitchell avatar Nov 22 '23 17:11 ndmitchell