buck2 icon indicating copy to clipboard operation
buck2 copied to clipboard

Make "Skipping target incompatible node" message tied to verbosity

Open dmzt99 opened this issue 2 years ago • 1 comments

Looks like we currently eprintln! "Skipping target incompatible node" in a few places, which ends up polluting the terminal regardless of verbosity level.

I can implement this if desired!

dmzt99 avatar Oct 23 '23 04:10 dmzt99

Definitely desired! We've love a patch. One approach is to turn that message into a proper event, and then it's easy to have it obey verbosity. Alternatively, you could make console_message obey verbosity. The former is probably the right thing to do, but I'm not totally sure.

ndmitchell avatar Nov 22 '23 19:11 ndmitchell