Use unique clap argument IDs

Open bvinc opened this issue 4 months ago • 2 comments

Running buck2 debug chrome-trace in debug mode would panic as clap has a debug assert to check for duplicate argument IDs. It is my understanding that duplicating argument IDs can cause bugs in release mode, even if they are under different subcommands.

Aug 04 '25 22:08 bvinc

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D79596226. (Because this pull request was imported automatically, there will not be any future comments.)

Aug 04 '25 22:08 facebook-github-bot

this fixes #1029, please add a note in the commit message :)

Aug 05 '25 05:08 lf-