buck icon indicating copy to clipboard operation
buck copied to clipboard
verified publisher icon facebook

[APPLE][WIP] XCFrameworks Support

Open Lcsmarcal opened this issue 4 years ago • 5 comments

Related to (#2594)

Lcsmarcal avatar Mar 03 '21 00:03 Lcsmarcal

Sorry for letting this stagnate @Lcsmarcal, do you mind rebasing? The circleci configs got updated to fix these jdk install failures that the circle ci jobs on your PR are failing on.

rajyengi avatar May 13 '21 02:05 rajyengi

Done @rajyengi. This PR is a work in progress, it can improved with buck developers (or the community itself) code review.

Edit: as a WIP, I didn't fix/write the integration tests. I can fix it if you want :)

Lcsmarcal avatar May 13 '21 14:05 Lcsmarcal

Yeah, I'd be great to have some tests for this new feature.

And that RustBinaryIntegrationTest is very flaky, if you can fix it (in a separate PR), I'll really appreciate that 🙂

KapJI avatar Jun 01 '21 16:06 KapJI

@Lcsmarcal is it still WIP?

KapJI avatar Aug 27 '21 17:08 KapJI

It would be great to get this merged. Anything I can help make that happen?

Thomvis avatar Apr 29 '22 11:04 Thomvis