buck icon indicating copy to clipboard operation
buck copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Problem with installation via homebrew

Open wesade opened this issue 4 years ago • 8 comments

Bildschirmfoto 2021-01-10 um 14 33 11

wesade avatar Jan 10 '21 13:01 wesade

Is this on BigSur? I believe some dependencies need to be updated first (https://github.com/facebook/buck/pull/2580)

rajyengi avatar Jan 11 '21 16:01 rajyengi

What do you mean by BigSur?

wesade avatar Jan 11 '21 16:01 wesade

need java 11 but homebrew formula add java 8 depency

hasayakey avatar Jan 21 '21 03:01 hasayakey

edit /usr/local/Homebrew/Library/Taps/facebook/homebrew-fb/buck.rb update line 20 to "openjdk@11"

hasayakey avatar Jan 21 '21 03:01 hasayakey

need java 11 but homebrew formula add java 8 depency

@wesade opened this issue 11 days ago, at then the latest release is v2020.10.21.01, I built it from source using the formula with openjdk@8 on BigSur without problem, so probably something else was off.

moshiba avatar Jan 21 '21 05:01 moshiba

Actually according to the latest stable release: v2021.01.12.01, looking at the CI config: https://github.com/facebook/buck/blob/v2021.01.12.01/.circleci/config.yml#L54 It suggests that even now buck is buildable using openjdk8

moshiba avatar Jan 21 '21 05:01 moshiba

I can reproduce it on macOS Catalina (10.15.7).

When I have adoptopenjdk-14 installed along with older java version it produces error mentioned. My JAVA_HOME is set to /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home version and ant -diagnostics shows java.version : 1.8.0_282..

But once I remove version java 14 then it installs ok. Seems like installation script ignores JAVA_HOME.

lexaurin avatar Feb 01 '21 11:02 lexaurin

I can reproduce it on macOS Catalina (10.15.7).

When I have adoptopenjdk-14 installed along with older java version it produces error mentioned. My JAVA_HOME is set to /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home version and ant -diagnostics shows java.version : 1.8.0_282..

But once I remove version java 14 then it installs ok. Seems like installation script ignores JAVA_HOME.

My bad, I realized that my environment was actually a bit messy. I have adoptopenjdk-8 installed (the old docs used to recommend this), and openjdk@8 installed (I suppose it has to do with Homebrew's new policy about casks being dependencies?), with all those installed my build was fine.

Anyway, @lexaurin, about your case, may I recommend a probably related PR: https://github.com/facebook/homebrew-fb/pull/52 ?

moshiba avatar Feb 03 '21 03:02 moshiba