Validation fixes are broken

[dschep]

Description

the missing_role validation (and maybe others?) quick fixes don't work.

I suspect the issue was introduced in #961 which replaced the onClick function at https://github.com/facebook/Rapid/blob/main/modules/validations/missing_role.js#L95 with a => style func, which given the use of this seems problematic.

Screenshots

Version

2.5.5

What browser are you seeing the problem on? What version are you running?

Firefox v141.0

The OS you're using

mac

Steps to reproduce

create a multipolygon relation and don't add inner/outer roles, when you click the fix to add inner or outer, nothing happens and you get an error in the console.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=20.82/37.50696/-77.43077&background=USGS-Imagery&id=r-1

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:141.0) Gecko/20100101 Firefox/141.0