Rapid icon indicating copy to clipboard operation
Rapid copied to clipboard

Reduce width of borders

Open hb0nd opened this issue 11 months ago • 4 comments

This is a minor issue (and maybe only bothers me), but the thicker borders around polygons really bothers me in Rapid - they feel more 'clunky', and have a small downside of obscuring edges of stuff on imagery, although admittedly likely not enough to matter, and wireframe mode also exists.

In summary, these thicker borders just feel wrong to me, and this issue is more to discuss with the wider community :)

iD left / Rapid right

Image

hb0nd avatar Jan 22 '25 00:01 hb0nd

In summary, these thicker borders just feel wrong to me, and this issue is more to discuss with the wider community :)

It is difficult for me to see the difference, but yes I guess Rapid's default stroke when drawing polygons is 2px and iD's is 1px. I don't remember changing this specifically, but I do think the Rapid one makes it a little easier to see where polygons are.

We could change the 2 to a 1 around these places to get them to look more the same, if people want this.

https://github.com/facebook/Rapid/blob/4d7b418f0e4a6d57c0ea9988b651d0f5327ad1d8/modules/core/StyleSystem.js#L90 https://github.com/facebook/Rapid/blob/4d7b418f0e4a6d57c0ea9988b651d0f5327ad1d8/modules/pixi/PixiFeaturePolygon.js#L298

bhousel avatar Jan 22 '25 00:01 bhousel

I'd love to have thinner outlines whenever im editing densely mapped areas

Swarkin avatar Jan 22 '25 17:01 Swarkin

Can it visually be 1px but selection triggers on 2px width? I'm worried that with 1px everybody will have to be snipers with precise mouse movements to select what they're aiming for.

mxxcon avatar Jan 23 '25 12:01 mxxcon

Can it visually be 1px but selection triggers on 2px width? I'm worried that with 1px everybody will have to be snipers with precise mouse movements to select what they're aiming for.

Yes, the hit area for the lines will still be a several-pixel-wide buffer around the line.

bhousel avatar Jan 23 '25 22:01 bhousel