Rapid icon indicating copy to clipboard operation
Rapid copied to clipboard

Validator should not expect "public_transport=platform_edge" to be an area

Open Lumikeiju opened this issue 1 year ago • 4 comments

Description

public_transport=platform_edge should actually always be a way, not an area / closedway.

Screenshots

upload

Version

2.3.2

What browser are you seeing the problem on? What version are you running?

Firefox 129.0.2

The OS you're using

Windows 10

Steps to reproduce

  1. Navigate to a way tagged with public_transport=platform_edge
  2. Open Issues panel

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=20.00/47.67683/-122.31741&id=w1272407159

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

Lumikeiju avatar Sep 02 '24 18:09 Lumikeiju

It doesn't look like a commonly used tags, but you're right that the examples I see are all ways. It makes sense to remove this validation check. Wdyt @atiannicelli?

eneerhut avatar Sep 26 '24 11:09 eneerhut

I don't see any documentation in the wiki for this tag. I do see railway=platform_edge which is always a way and not an area. Seems like the validation check probably should be dropped since the tag is not a defined tag in the wiki.

atiannicelli avatar Oct 01 '24 20:10 atiannicelli

I don't see any documentation in the wiki for this tag. I do see railway=platform_edge which is always a way and not an area. Seems like the validation check probably should be dropped since the tag is not a defined tag in the wiki.

Documentation is here: https://wiki.openstreetmap.org/wiki/Tag:public_transport%3Dplatform_edge

Lumikeiju avatar Oct 01 '24 22:10 Lumikeiju

Weird!!! When looked for it earlier I didn't find it.

Well, in that case I am in full agreement with removing that validation or changing it to make sure that it is a way and not an area.

atiannicelli avatar Oct 01 '24 22:10 atiannicelli

I checked this again and I'm not seeing this warning anymore as of Rapid v2.5.0 👍 I'm pretty sure it was fixed as a result of 7b115b87 , which makes it so that we don't raise "invalid geometry" warnings anymore if the feature doesn't match a known preset.

bhousel avatar Jan 07 '25 19:01 bhousel