Rapid icon indicating copy to clipboard operation
Rapid copied to clipboard

KartaView photos seems broken

Open bhousel opened this issue 6 months ago • 0 comments

When enabling the KartaView photo layer, the requests fail with 400 Bad Request.

Screenshot 2024-08-07 at 12 31 50 PM

Looks like it is related to these lines: https://github.com/facebook/Rapid/blob/695d7f2fa93aaea4b98a2139157922956699fd8b/modules/services/KartaviewService.js#L449-L453

...because currZoom can be float and _maxPageAtZoom expects integers. This means maxPages will end up 'false', Then the (nextPage > maxPages) comparison will fail, Then we'll try fetching page Infinity, triggering the bad request.

bhousel avatar Aug 07 '24 16:08 bhousel