facebook
Pedestrian Focus Mode
The Pedestrian Focus Mode, accessible through the preferences panel, aims to reduce visual clutter and improve the clarity of pedestrian-friendly routes. This pull request builds upon PR #1230, which introduced a color scheme and colorblind mode system.
Changes:
- Implemented logic to highlight pedestrian infrastructure
- Ajusted rendering to grey out non-pedestrian elements
- Added radio buttons to Preference panel to toggle between pedestrian/default mode
- Added hotkey (Alt + P) that enables Pedestrian Focus mode
Notes:
- Map elements tagged with foot=use_sidepath are considered as pedestrian infrastructure in this mode
- Pedestrian Focus Mode is compatible with the existing color scheme and colorblind modes
- There's not a lot of real estate when it comes to the keyboard shortcuts; Alt + P seems to work on most browsers on Windows
Hi @salvinax!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
I have been doing a lot of work on a very similar topic which is bike infrastructure. I am very happy to chat about what tagging issues we ran into when mapping bike/foot infrastructure on the centerline and as separate geometry.
For our mapping campaign https://wiki.openstreetmap.org/wiki/Brandenburg/Kampagne_Radnetz we used iD to help volunteers that don't know a lot about OSM or this kind of mapping to help add data. That is a great learning experience that I am happy to share.
A few quick notes
- Some infrastructure is still a lot easier to map quickly on the centerline and for some regions (rural areas) that is also quite OK. But we need https://wiki.openstreetmap.org/wiki/Brandenburg/Kampagne_Radnetz to expose more centerline data and make it easier to map this in iD/Rapid. And also https://github.com/facebook/Rapid/issues/1338.
- Syncing the centerline and separate geometries is still way too hard. We focussed on the presence tagging of infrastructure (
cycleway:left|right|both|null=separate,sidewalk:left|right|both|null=separate) but there are also the access tags (bicycle:left|right|both|null=use_sidepath|…andfoot:left|right|both|null=use_sidepath|…) - There is no help, yet to find places where infrastructure was mapped twice, once on the centerline and once separate. Our https://radverkehrsatlas.de/ will show this for bike lanes in the given region, but explicit styles that show this right in the editor would be great
- One piece of this puzzle is to handle separate infra vs. centerline is https://wiki.openstreetmap.org/wiki/Proposal:Key:is_sidepath. We recently sharpened the proposal and the tag helps us a lot when processing the data.
This might conflict pretty hard against the work being done on #1384 - are you and @chinweibegbu working together on this?
This might conflict pretty hard against the work being done on #1384 - are you and @chinweibegbu working together on this?
Yes, they are! Both features would need some reconciliation/merging once they've collected feedback from us in both these PRs. I asked them to create draft branches to collect feedback via separate draft PRs, but the idea is they'd collapse together after that feedback.
Short video I captured of this feature in action in a busy intersection in amsterdam:
https://github.com/facebook/Rapid/assets/1887955/23b58cf2-ad43-44d0-be3f-62de8f0ea00e