Assume that features are accepted when using the hotkey to move and rotate

[Martinligabue]

Description

When editing, it is common to accidentally press M or R to rotate a building or road that has not yet been accepted, the editor should instead assume that it was intended to accept the feature, and should start moving or rotating automatically. It might be useful to extend this feature to other hotkeys, such as C, which could merge the newly accepted road as a continuation of the existing one.

[bhousel]

I like this idea.. I'd even take it a step further and say that if the user is just hovering over a rapid feature, we should allow all the shortcuts to work.

[misibacsi]

I support this request, I also wanted to ask this feature to speed up the editing process.

[jemcmullin]

(ended up here from issue 1625 reference) Testing the hover + A key in the canary build, was less ideal than I expected since the added building is highlighted/focused after add. I had to select the next AI building anyway to be able to add subsequent buildings or alternate with the Esc key. I was expecting to be able to hover+add multiple times without selection. Could this implementation be refactored to not select the added building?

[bhousel]

. I was expecting to be able to hover+add multiple times without selection. Could this implementation be refactored to not select the added building?

Thanks for the feedback - this sounds good 👍 A doesn't need to select the feature.

[bhousel]

I did this today, and tested a bunch with Rapid to see how it feels. It can really improve mapping efficiency!

When a Rapid feature is selected or hovered the following will apply:

• If feature was selected and we hit A, accept and select the newly added feature
• If feature was just hovering and we hit A, hover (but don't select) the newly added feature
• If we hit M to move or R to rotate, accept, then select and enter that mode instead

This tries to capture most of the suggestions on this ticket.

Also, because of key-repeat, there is now this fun side-effect where you can just hold down A and hover over a lot of stuff:

We experimented with this in #268 but ultimately didn't add it - this new change feels a lot better because the user needs to be holding down A to do this - adding things on hover becomes very intentional.

[jjiglesiasg]

I tested in Riberalta - Bolivia and the floating over and acceptance do not work, unless you start selecting an inferred element and accepting, from that point works the floating and acceptance. But you need to repeat this process again and again

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free.www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Wed, Dec 18, 2024 at 12:28 PM Bryan Housel @.***> wrote:

I did this today, and tested a bunch with Rapid to see how it feels. It can really improve mapping efficiency!

When a Rapid feature is selected or hovered the following will apply:

• If feature was selected and we hit A, accept and select the newly added feature
• If feature was just hovering and we hit A, hover (but don't select) the newly added feature
• If we hit M to move or R to rotate, accept, then select and enter that mode instead

This tries to capture most of the suggestions on this ticket.

Also, because of key-repeat, there is now this fun side-effect where you can just hold down A and hover over a lot of stuff:

hover.add.gif (view on web) https://github.com/user-attachments/assets/59fe3830-166c-4963-a16c-061860edc092

We experimented with this in #268 https://github.com/facebook/Rapid/pull/268 but ultimately didn't add it

• this new change feels a lot better because the user needs to be holding down A to do this - adding things on hover becomes very intentional.

— Reply to this email directly, view it on GitHub https://github.com/facebook/Rapid/issues/1336#issuecomment-2551768881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOKQKV32VQF2J65E5G2O632GGPCFAVCNFSM6AAAAABTLUIM5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRG43DQOBYGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Juan Jose Iglesias Technical Field Representative Ph/Wa: +591 72213368 Skype: jjiglesiasg

[bhousel]

I tested in Riberalta - Bolivia and the floating over and acceptance do not work, unless you start selecting an inferred element and accepting, from that point works the floating and acceptance. But you need to repeat this process again and again

oh - did you try with canary build? This is unreleased yet, but hover + A does work when I try it in Riberalta here:

https://rapideditor.org/canary#map=19.83/-11.05542/-66.04580&background=Bing&datasets=fbRoads,msBuildings

(yes, I would rotate these buildings better if I were really adding them)