Building shapes become too simplified above zoom level 16

[davidsalmon-tomtom]

Description

It's not clear if this is a bug or if this intentional for performance but I've noticed that building shapes become overly simplified at zoom level 16 or zoomed out further. At zoom level 17 they appear as expected.

This may be related to: https://github.com/facebook/Rapid/issues/557 or https://github.com/facebook/Rapid/issues/552.

Screenshots

Zoom level 16 Zoom level 17

Version

2.2.4

What browser are you seeing the problem on? What version are you running?

Firefox v122.0

The OS you're using

win

Steps to reproduce

1. Browse to a location
2. Go to Zoom Level 16
3. Zoom in closer to Level 17

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#background=MAPNIK&datasets=fbRoads,msBuildings&disable_features=boundaries&id=r366146&map=16.00/43.3978/-71.9598

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:122.0) Gecko/20100101 Firefox/122.0

[bhousel]

Thanks for reporting, this is an intentional performance trick.. We swap out the detailed polygon shapes for a low resolution sprite once it is smaller than around 20x20 pixels. This is useful because Pixi can draw sprites nearly for free, and at this small size, they are really too small for the user to be dragging their vertices around.

Currently it can only replace the shapes with a box or an oval - I think it would be nice to provide a few other stand in simplified shapes.

Here's a video of it in action (in this video the shapes turn blue to show which ones are affected):

https://github.com/facebook/Rapid/assets/38784/dd31774c-5a33-4707-b6a6-e0c429e2c9df

[jjiglesiasg]

I see no issues with what is shown in your video