Rapid icon indicating copy to clipboard operation
Rapid copied to clipboard

Show crosswalk marking icons in marking type dropdown

Open cbeddow opened this issue 2 years ago • 5 comments

Description

image

In this dropdown when editing a crosswalk, it would be awesome to show some graphic of the crossing type, similar to below:

image

I can work on making an SVG for each type if it is potentially able to be displayed next to the text there.

This would not be reflected in the actual icon of the preset.

cbeddow avatar Dec 11 '23 17:12 cbeddow

Cool - this feature did get added to iD last year, so if people find it useful we could support it in Rapid too.
I think most of the types do have icons assigned.
see: https://github.com/ideditor/schema-builder/issues/56

bhousel avatar Dec 11 '23 17:12 bhousel

Yes, very useful feature to have. No need to remember the given names to different markings, especially since those names are often different from the tag values and on less commonly used types. Just look for the matching icon and select it 😄 Please add it.👍 image

mxxcon avatar Dec 20 '23 23:12 mxxcon

Working on this today - it would be nice to get this into a patch release this week!

The ones shipped with iD are not drawn in a way that we can use them on markers, so I'll probably just redraw them. The are all pretty simple shapes.

Screenshot 2023-12-27 at 1 01 23 PM

bhousel avatar Dec 27 '23 18:12 bhousel

Getting closer! The shapes are still just a bit too dense to work at 15px map pin size. I'll refine them a bit more.

Screenshot 2023-12-27 at 9 24 56 PM

bhousel avatar Dec 28 '23 02:12 bhousel

I realized I forgot to followup on this - the new presets actually shipped in yesterday's patch release v2.2.2 🎉

I did a lot of work to make sure they look pretty good at both the 40px preset icon size and the 15px map pin size. see: https://rapideditor.github.io/temaki/docs/#group=crossings

The hope is that users scrolling around the map should be able to tell which crossings are mapped with crossing:markings detail.

I'll leave this issue open for now, because I haven't yet updated the dropdown component to show inline icons yet.

bhousel avatar Jan 03 '24 19:01 bhousel