IT-CPE
IT-CPE copied to clipboard
Updating rights to support non-English OSs
What type of PR is this? /kind feature
What this PR does / why we need it: This PR will change the rights assignment on Windows files and directories to use SID instead of English-based principals. This change is needed to support non-English Windows OS languages Which issue(s) this PR fixes:
Fixes #269
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Additional documentation e.g., Design Proposals, usage docs, etc.:
Hi @gleason86!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@HeyItsGilbert has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.