Haxl icon indicating copy to clipboard operation
Haxl copied to clipboard

Bump dependencies and CI

Open andreasabel opened this issue 1 year ago • 3 comments

  • include latest GHCs in CI
  • latest minor version is determined by haskell-actions/setup
  • freeze file is a bad cache key as it contains a time stamp, use the build plan instead (the correct choice)

Successful CI run at: https://github.com/andreasabel/Haxl/actions/runs/6725224644

andreasabel avatar Nov 01 '23 20:11 andreasabel

@simonmar : PR ready

andreasabel avatar Nov 01 '23 21:11 andreasabel

Hi @andreasabel ! Thanks for the patch! Unfortunately it looks like it's broken for 9.4.

josefs avatar Nov 13 '23 16:11 josefs

@josefs: Thanks for taking a look!

Seems like this test breaks on 9.4: https://github.com/facebook/Haxl/actions/runs/6725225214/job/18629935821?pr=158#step:8:150

:OutgoneFetchesTest:
  :finished: [Failed]
fetchesMap
expected: fromList []
 but got: fromList [("Sleep",fromList [(ConcurrentIOReq Sleep,1)])]

Here is the source: https://github.com/facebook/Haxl/blob/6cd30c084debcde9bb83e0f517bbe98cdd80e945/tests/OutgoneFetchesTests.hs#L40-L58

I can see timeouts and sleeps here...

Let me boldly claim that nothing is wrong with my PR but something is wrong with this test...

andreasabel avatar Dec 08 '23 05:12 andreasabel