Ax icon indicating copy to clipboard operation
Ax copied to clipboard

use benchmark_trial in dev_api

Open sdaulton opened this issue 3 years ago • 3 comments

Summary: Currently trial.fetch_data() is never called so no data is attached to the experiment

Differential Revision: D32583353

sdaulton avatar Nov 21 '21 02:11 sdaulton

This pull request was exported from Phabricator. Differential Revision: D32583353

facebook-github-bot avatar Nov 21 '21 02:11 facebook-github-bot

Codecov Report

Merging #728 (ac011ec) into main (6bccfb4) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   93.15%   93.17%   +0.01%     
==========================================
  Files         366      366              
  Lines       31605    31606       +1     
==========================================
+ Hits        29443    29448       +5     
+ Misses       2162     2158       -4     
Impacted Files Coverage Δ
ax/benchmark/benchmark.py 82.75% <100.00%> (+2.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bccfb4...ac011ec. Read the comment docs.

codecov-commenter avatar Nov 21 '21 02:11 codecov-commenter

Hi @sdaulton!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 09 '22 09:01 facebook-github-bot