Disallow attaching data for trials that have not been attached

[esantorella]

Summary: Disallows attaching data for trials that have not been attached. Experiment's data-lookup functions typically assume that experiment.trials.keys() is the set of all trials with data, which is not necessarily true if data has been attached for trial indices that have not been attached.

Question: Should this be a warning first?

Differential Revision: D87002982

[meta-codesync[bot]]

@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87002982.

[codecov-commenter]

Codecov Report

:x: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 96.57%. Comparing base (769e0d1) to head (ad515c7).

Files with missing lines	Patch %	Lines
ax/core/map_data.py	80.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4539      +/-   ##
==========================================
- Coverage   96.57%   96.57%   -0.01%     
==========================================
  Files         548      548              
  Lines       56447    56459      +12     
==========================================
+ Hits        54514    54523       +9     
- Misses       1933     1936       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.