Remove `data` option from `Experiment.clone_with`

[esantorella]

Summary: I do not see usages of Experiment.clone_with(data=...), which is good, because it has a couple issues:

• A trial on the old experiment might have a different index on the new experiment. This is accounted for in the data=None case, but not when data is not None, so metrics would be attached to the wrong trials.
• trial_indices are ignored when Data is not None, so the new experiment could wind up with data for trials that aren't on it.

Differential Revision: D87004006

[meta-codesync[bot]]

@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87004006.

[codecov-commenter]

Codecov Report

:x: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 96.57%. Comparing base (769e0d1) to head (634032f).

Files with missing lines	Patch %	Lines
ax/core/map_data.py	80.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4538      +/-   ##
==========================================
- Coverage   96.57%   96.57%   -0.01%     
==========================================
  Files         548      548              
  Lines       56447    56453       +6     
==========================================
+ Hits        54514    54517       +3     
- Misses       1933     1936       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.