Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Make transition_to a required argument on MaxGenParallelism

Open mgarrard opened this issue 1 month ago • 2 comments

Summary: This is step 1 to making transition_to a required argument on TC. We'll make maxparallelism point to self, since it should stay on it's current node when met or unmet.

Differential Revision: D86066476

mgarrard avatar Nov 05 '25 23:11 mgarrard

@mgarrard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86066476.

meta-codesync[bot] avatar Nov 05 '25 23:11 meta-codesync[bot]

Codecov Report

:x: Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 96.58%. Comparing base (503cc7b) to head (2aeae97).

Files with missing lines Patch % Lines
ax/generation_strategy/generation_strategy.py 88.23% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4507      +/-   ##
==========================================
- Coverage   96.58%   96.58%   -0.01%     
==========================================
  Files         546      546              
  Lines       56058    56019      -39     
==========================================
- Hits        54143    54104      -39     
  Misses       1915     1915              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 05 '25 23:11 codecov-commenter