Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Implement Chebyshev center fallback for center node

Open mgarrard opened this issue 1 month ago • 2 comments

Summary: This diff implements Chebyshev center if naive centering fails due to violation of parameter constraints.

Differential Revision: D85712042

mgarrard avatar Oct 29 '25 18:10 mgarrard

@mgarrard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85712042.

meta-codesync[bot] avatar Oct 29 '25 18:10 meta-codesync[bot]

Codecov Report

:x: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 96.56%. Comparing base (8f5d7d0) to head (2383422).

Files with missing lines Patch % Lines
ax/generation_strategy/center_generation_node.py 96.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
- Coverage   96.56%   96.56%   -0.01%     
==========================================
  Files         551      551              
  Lines       56892    56953      +61     
==========================================
+ Hits        54940    54998      +58     
- Misses       1952     1955       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Oct 29 '25 19:10 codecov-commenter