Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Soft-deprecate combine_with_last_data arg, setting it as `not overwrite_existing_data`

Open bernardbeckerman opened this issue 3 months ago • 8 comments

Summary: Diff contents:

  • Soft-deprecates combine_with_last_data arg in Experiment.attach_data signature, docs, and logic.
  • For all passthrough callsites, updates signature and docs.
  • Removes all direct specification of combine_with_last_data=True/False, ensuring that the same behavior remains after the change (i.e., overwrite_existing_data is not combine_with_last_data).

Reviewed By: saitcakmak

Differential Revision: D75696517

bernardbeckerman avatar Aug 27 '25 17:08 bernardbeckerman

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 17:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 17:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 17:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 18:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 18:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 19:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D75696517

facebook-github-bot avatar Aug 27 '25 19:08 facebook-github-bot

@bernardbeckerman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D75696517.

meta-codesync[bot] avatar Oct 02 '25 20:10 meta-codesync[bot]