Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Use name of enum instead of casting to string

Open bernardbeckerman opened this issue 1 month ago • 2 comments

Summary: Keys.PAIRWISE_PREFERENCE_QUERY or str(Keys.PAIRWISE_PREFERENCE_QUERY) is commonly used when a string is expected, whereas I'm suspecting the intention is Keys.PAIRWISE_PREFERENCE_QUERY.name. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe.

Differential Revision: D56850035

bernardbeckerman avatar May 02 '24 13:05 bernardbeckerman