Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Don't pass `metric_names` to BoTorchModel.fit, because it is unused

Open esantorella opened this issue 4 months ago • 2 comments

Summary: Prior to D53814087, metric_names could be be passed to BoTorchModel.fit as a named argument. After D53814087, if metric_names are passed they are absorbed into **additional_model_inputs and eventually ignored. Starting in D53086323 (https://github.com/pytorch/botorch/pull/2186), such inputs will error rather than be ignored.

Differential Revision: D54320622

esantorella avatar Feb 28 '24 19:02 esantorella