Ax
Ax copied to clipboard
Fix torchx import error
Summary:
from ax.runners.torchx import TORCHX_TRACKER_BASE
leads to an import error in Python 3.7 unit tests. Moving this into try/except block to get around the issue.
Example failing run https://github.com/facebook/Ax/runs/6891472698?check_suite_focus=true
Reviewed By: mpolson64
Differential Revision: D37162339
This pull request was exported from Phabricator. Differential Revision: D37162339
This pull request was exported from Phabricator. Differential Revision: D37162339
Codecov Report
Merging #1001 (eda7715) into main (369d41b) will increase coverage by
0.01%
. The diff coverage is95.91%
.
@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 94.12% 94.14% +0.01%
==========================================
Files 404 404
Lines 35002 35005 +3
==========================================
+ Hits 32947 32956 +9
+ Misses 2055 2049 -6
Impacted Files | Coverage Δ | |
---|---|---|
ax/runners/tests/test_torchx.py | 96.49% <95.83%> (+0.19%) |
:arrow_up: |
ax/metrics/torchx.py | 58.62% <100.00%> (+10.34%) |
:arrow_up: |
ax/runners/torchx.py | 98.18% <0.00%> (+5.45%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 369d41b...eda7715. Read the comment docs.
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@saitcakmak looks like D37162339 landed - did the bot fail to close this?
@balandat Yeah, it's not a one-off issue either. There are a bunch of other open PRs that were landed. Maybe there's an issue with the bot config for Ax?
already committed