kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Published 20 hours ago • verified publisher icon fabric8io

chore(deps): bump com.approvaltests:approvaltests from 24.3.0 to 24.4.0

Open dependabot[bot] opened this issue 1 year ago • 6 comments

Bumps com.approvaltests:approvaltests from 24.3.0 to 24.4.0.

Release notes

Sourced from com.approvaltests:approvaltests's releases.

Support for setting reporter in environment variables

See #520

See the documentation here.

Thanks to @​FWest98 for this contribution!

Commits
  • dddfa87 . e don't compile with java 17, we still want to be compatible with 8
  • ea21b5a . d updated markdown snippets
  • eade3a8 . r delete dead code
  • bf30864 . dt document currently supported Reporters when using EnvironmentalVariableR...
  • c7fb16a . t dont set env variables globally to test EnvironmentVariableReporter
  • a80c919 . d updated markdown snippets
  • c7d6ee7 Merge pull request #520 from FWest98/fw/environmentreporter
  • 4b77319 Merge branch 'master' into fw/environmentreporter
  • 2fd1953 a reformat code
  • f45f668 . td Documenting Test update on Step 6
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Aug 13 '24 11:08 dependabot[bot]

Build is failing on JDK8 due to NoClassDefFoundError

 Errors: 
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV1ApprovalTest:92 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoSuchMethod java.util.Map.entry(Ljava/lang/Object;Ljava/lang/Object;)Ljava/util/Map$Entry;
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter
Error:    CRDGeneratorApprovalTest.apiV2ApprovalTest:118 » NoClassDefFound Could not initialize class org.approvaltests.reporters.DefaultFrontLoadedReporter

However, I'm unable to reproduce this issue on JDK11 and JDK17.

It's not worth investing fixing this test on JDK8 as we're going to bump to JDK11 soon. I think we can just disable this test on JDK 8 or merge this after #6081 is fixed

rohanKanojia avatar Aug 26 '24 10:08 rohanKanojia

However, I'm unable to reproduce this issue on JDK11 and JDK17.

Are you sure these tests are running on those JDKs?

manusa avatar Aug 26 '24 13:08 manusa

I tried it again but this test is passing on JDK11 and JDK17.

In the error stack trace I see this:

 NoSuchMethod java.util.Map.entry(Ljava/lang/Object;Ljava/lang/Object;)Ljava/util/Map$Entry;

It's javadoc says it's introduced since Java 9

rohanKanojia avatar Aug 26 '24 13:08 rohanKanojia

Just making sure that the test(s) is not ignored in other JDKs besides 8 and is actually executed.

It's weird (probably a mistake) that they made the library require Java 9+ in a minor release. It might be worth reporting it upstream.

manusa avatar Aug 26 '24 13:08 manusa

I've created https://github.com/approvals/ApprovalTests.Java/issues/546

rohanKanojia avatar Aug 26 '24 13:08 rohanKanojia

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Sep 11 '24 01:09 sonarqubecloud[bot]

If this gets bumped to 24.5.0 it should work again on jdk 8. We just released, maybe dependabot updates this PR on it's own.

LarsEckart avatar Sep 16 '24 18:09 LarsEckart

Awesome, thanks @LarsEckart I created #6349 for the manual update

manusa avatar Sep 17 '24 04:09 manusa

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Sep 17 '24 04:09 dependabot[bot]