kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Model has lombok.Setter when is not needed

Open jorsol opened this issue 1 year ago • 3 comments

Describe the bug

Almost all the models are annotated with @Setter but the setters seem to be explicitly generated.

Fabric8 Kubernetes Client version

SNAPSHOT

Steps to reproduce

https://github.com/fabric8io/kubernetes-client/blob/409be3b32de4f0f7d74d99186b4df98c042d0132/kubernetes-model-generator/kubernetes-model-core/src/generated/java/io/fabric8/kubernetes/api/model/Pod.java#L36

Expected behavior

The annotation should not be present when the setter is already generated:

https://github.com/fabric8io/kubernetes-client/blob/409be3b32de4f0f7d74d99186b4df98c042d0132/kubernetes-model-generator/kubernetes-model-core/src/generated/java/io/fabric8/kubernetes/api/model/Pod.java#L106

Runtime

other (please specify in additional context)

Kubernetes API Server version

1.25.3@latest

Environment

other (please specify in additional context)

Fabric8 Kubernetes Client Logs

No response

Additional context

This seems to be harmless and Lombok does not generate the setters if found one, but having one less annotation that does magical stuff is better.

jorsol avatar Jul 02 '24 11:07 jorsol