kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

chore(deps): bump org.projectlombok:lombok from 1.18.32 to 1.18.34

Open dependabot[bot] opened this issue 1 year ago • 1 comments

Bumps org.projectlombok:lombok from 1.18.32 to 1.18.34.

Changelog

Sourced from org.projectlombok:lombok's changelog.

v1.18.34 (June 28th, 2024)

  • PLATFORM: Added support for Eclipse 2024-06; you'd get some NoSuchMethodError traces in your logs if using @Builder or @Singular prior to this fix. [Issue #3638](projectlombok/lombok#3638).
  • IMPROBABLE BREAKING CHANGE: Lombok now adds @lombok.Generated by default to methods and types it generates. This may result in accidentally increasing your test coverage percentage. [Issue #3667](projectlombok/lombok#3667).
  • IMPROBABLE BREAKING CHANGE: When lombok.config contains lombok.onX.flagUsage = WARNING, from now on warnings will actually be generated if onX is used.[Issue #2848](projectlombok/lombok#2848)
  • BUGFIX: When @SuperBuilder was used on a type with an generic array type, it would error wrong number of type arguments. [Issue #3694](projectlombok/lombok#3694).
  • FEATURE: Lombok generates javadoc for you for most of the methods it adds; with this release, javadoc is also added to generated constructors. [Issue #933](projectlombok/lombok#933).
Commits
  • fbbe7f0 [release] pre-release version bump
  • 3cd41e8 [trivial] some test cases were failing (due to the constructor-javadoc update...
  • 1384244 Merge pull request #3698 from stevebosman/fix-sneaky-throws-doc
  • d90ec73 [trivial] [style]
  • 3b68e39 Merge pull request #3697 from janrieke/superbuilder-fix-array-type-param
  • fdafa9a Merge pull request #3690 from Rawi01/eclipse_2024_06
  • 78c1f47 Merge pull request #3689 from Rawi01/nested-javadoc
  • da815a6 Merge pull request #3674 from Rawi01/standardexception-fields
  • c61a404 [trivial]
  • 6cf6caf Merge pull request #3673 from Rawi01/eclipse_field_generated
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Jun 28 '24 11:06 dependabot[bot]

Build is failing :

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project openshift-client-api: Compilation failure
Error:  cannot access lombok.Generated
Error:    class file for lombok.Generated not found
Error:    Consult the following stack trace for details.
Error:    com.sun.tools.javac.code.Symbol$CompletionFailure: class file for lombok.Generated not found
Error:  -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project openshift-client-api: Compilation failure
cannot access lombok.Generated
  class file for lombok.Generated not found
  Consult the following stack trace for details.
  com.sun.tools.javac.code.Symbol$CompletionFailure: class file for lombok.Generated not found

rohanKanojia avatar Jun 28 '24 11:06 rohanKanojia

@dependabot rebase

rohanKanojia avatar Jul 12 '24 13:07 rohanKanojia

I see this issue happening only on JDK8. On JDK11and JDK17 I'm not able to reproduce this issue.

rohanKanojia avatar Jul 15 '24 04:07 rohanKanojia

I see this issue happening only on JDK8. On JDK11and JDK17 I'm not able to reproduce this issue.

That's weird. What initially was some side effect of:

IMPROBABLE BREAKING CHANGE: Lombok now adds @lombok.Generated by default to methods and types it generates. This may result in accidentally increasing your test coverage percentage. [Issue #3667](projectlombok/lombok#3667).

manusa avatar Jul 15 '24 05:07 manusa

Providing lombok.addLombokGeneratedAnnotation = false in lombok.conig seems to fix the issue. However, I'm not sure we want to opt out of this functionality.

rohanKanojia avatar Jul 15 '24 07:07 rohanKanojia