kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

add DeploymentConfigRollback object to openshift model

Open mluckam opened this issue 1 year ago • 6 comments

Description

added DeploymentConfigRollback object to openshift model https://docs.openshift.com/container-platform/4.10/rest_api/workloads_apis/deploymentconfigrollback-apps-openshift-io-v1.html

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [X] Code contributed by me aligns with current project license: Apache 2.0
  • [X] I Added CHANGELOG entry regarding this change
  • [X] I have implemented unit tests to cover my changes
  • [X] I have added/updated the javadocs and other documentation accordingly
  • [X] No new bugs, code smells, etc. in SonarCloud report
  • [X] I tested my code in Kubernetes
  • [X] I tested my code in OpenShift

mluckam avatar Mar 01 '24 16:03 mluckam

@mluckam : Could you please add a test for this? See existing tests.

rohanKanojia avatar Mar 01 '24 17:03 rohanKanojia

@rohanKanojia unit test has been added.

mluckam avatar Mar 01 '24 18:03 mluckam

@mluckam : What is the use case for this change? How do you plan to use this object from openshift-model? Do you also plan to make subsequent changes in OpenShiftClient DSL ?

rohanKanojia avatar Mar 04 '24 13:03 rohanKanojia

The DeploymentConfigRollback is utilized to rollback a DeploymentConfig via the API path "/apis/apps.openshift.io/v1/namespaces/{namespace}/deploymentconfigs/{name}/rollback", see documentation. The model DeploymentConfigRollback was not currently in this project, but available in the dependent model project.

Currently I am migrating to utilizing the kubernetes and openshift models from this project. Once the models from this project are utilized, a next step would be to transition from interacting with the API via an HTTP client, to utilizing the OpenShiftClient. This may be several months away though. Until this migration occurs, I do not have plans to update the OpenShiftClient DSL.

mluckam avatar Mar 04 '24 16:03 mluckam

@mluckam : Could you please create an issue for /rollback support in OpenShiftClient DSL?

rohanKanojia avatar Mar 04 '24 16:03 rohanKanojia