kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

[extensions/istio] : LoadBalancerSettingsSimpleLB can`t found the LEAST_REQUEST

Open frankywen opened this issue 1 year ago • 7 comments

Is your enhancement related to a problem? Please describe

in LoadBalancerSettingsSimpleLB can`t found the LEAST_REQUEST

Describe the solution you'd like

add LEAST_REQUEST to LoadBalancerSettingsSimpleLB class

Describe alternatives you've considered

No response

Additional context

No response

frankywen avatar Nov 09 '23 03:11 frankywen

Related to https://github.com/fabric8io/kubernetes-client/issues/5182 The java model for Istio extension seems to be a bit outdated. We need to update it as per latest releases.

If you have time, please help us in updating the model.

rohanKanojia avatar Nov 09 '23 08:11 rohanKanojia

Hey, @rohanKanojia ! I would like to work on it with some guidance. And help to update as per latest release.

abhayporwals avatar Nov 09 '23 11:11 abhayporwals

You would need to update the dependencies listed in istio generator to latest available versions:

https://github.com/fabric8io/kubernetes-client/blob/b8d5ce45d9583d5e7d9a4aa2718d45eb05eae89b/extensions/istio/generator-v1beta1/go.mod#L6-L14

Then run go mod tidy and then make afterward. There are going to be some errors during make since we haven't upgraded since a long time.

rohanKanojia avatar Nov 10 '23 04:11 rohanKanojia

Ok @rohanKanojia ! Got everything. I'm starting to work on it and raise the PR as soon as possible. And will let you know if I need any help within it. You can assign it to me 🙂

abhayporwals avatar Nov 10 '23 05:11 abhayporwals

@manusa should we move the extensions in this repo to use the java-generator ? Following your example: https://github.com/fabric8io/kubernetes-client/compare/main...manusa:kubernetes-client:extension/kubevirt

I have quickly attempted to generate the Istio Client and everything seems good apart from a couple of rough edges in sundrio. thoughts?

andreaTP avatar Nov 10 '23 11:11 andreaTP

same issue, looking forward to the new version

mailingfeng avatar Nov 27 '23 06:11 mailingfeng

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

stale[bot] avatar Feb 25 '24 14:02 stale[bot]

This issue should be fixed by Istio model upgrade PR https://github.com/fabric8io/kubernetes-client/pull/5903

I'm able to see LEAST_REQUEST in LoadBalancerSettingsSimpleLB enum

rohanKanojia avatar Apr 16 '24 10:04 rohanKanojia

@mailingfeng @frankywen : Istio Extension should now be upgraded to Istio v1.21.0 . You should be able to try out the SNAPSHOT version after today's nightly build. Would be great if you could try it out and provide feedback.

In order to use 6.13-SNAPSHOT, You need to add this to your project's pom.xml or ~/.m2/settings.xml

      <repositories>
        <repository>
          <id>sonatype-snapshots</id>
          <url>https://oss.sonatype.org/content/repositories/snapshots</url>
          <releases><enabled>false</enabled></releases>
          <snapshots><enabled>true</enabled></snapshots>
        </repository>
      </repositories>

rohanKanojia avatar Apr 19 '24 08:04 rohanKanojia

Good Jod,nice~!

mailingfeng avatar Aug 16 '24 01:08 mailingfeng