kubernetes-client
kubernetes-client copied to clipboard
addedIsBlank/isNotBlank_Utils
Description
Added Utils.isBlank() and Utils.isNotBlank() fixes #4057
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change
- [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)
Checklist
- [x] Code contributed by me aligns with current project license: Apache 2.0
- [ ] I Added CHANGELOG entry regarding this change
- [ ] I have implemented unit tests to cover my changes
- [ ] I have added/updated the javadocs and other documentation accordingly
- [ ] No new bugs, code smells, etc. in SonarCloud report
- [ ] I tested my code in Kubernetes
- [ ] I tested my code in OpenShift
Hi @manusa @rohanKanojia can you please review the PR
@aditya-32 : Could you please link the issue which this PR intends to fix?
Hi @rohanKanojia fixes issue: #4057 updated the description
I see. Could you please write some unit tests for this? You would also need to check and update other places where we're using == null/ != null etc checks.
Hi @rohanKanojia can you please review it , i have added unit test cases and replaced instances of ==null and != null with the use of Utils.isBlank() and Utils.isNotBlank() . Also please suggest any changes if needed or any where you see i can replace null check with utils.isBlank().
@rohanKanojia @manusa can you please review the PR
any update on the PR ? can we review this








