kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Fix #4287: add WorkloadGroup for istio v1alpha3 generator

Open yimoucao opened this issue 1 year ago • 3 comments

Description

Fix #4287

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [ ] Code contributed by me aligns with current project license: Apache 2.0
  • [ ] I Added CHANGELOG entry regarding this change
  • [ ] I have implemented unit tests to cover my changes
  • [ ] I have added/updated the javadocs and other documentation accordingly
  • [ ] No new bugs, code smells, etc. in SonarCloud report
  • [ ] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

yimoucao avatar Jul 28 '22 19:07 yimoucao

@manusa or @Sgitario how to bypass Schema files modified. Build Failure ? my change definitely will update schema

yimoucao avatar Jul 28 '22 20:07 yimoucao

Hi @yimoucao,

Thx for your contribution.

@manusa or @Sgitario how to bypass Schema files modified. Build Failure ? my change definitely will update schema

You need to regenerate the schema and persist those files ---> run the ./kubernetes-model-generator/generateModelDocker.sh script, check and commit the generated sources.

manusa avatar Aug 09 '22 10:08 manusa

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Aug 11 '22 00:08 sonarcloud[bot]