kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Fix home dir win

Open sunix opened this issue 2 years ago • 4 comments

Description

This should fix problem occured in https://github.com/eclipse/jkube/issues/1540 Resolving the folder where .kube/config shoud be located, it should behave like oc and kubectl: On Windows, looking at the the HOME env variable at first.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [x] Code contributed by me aligns with current project license: Apache 2.0
  • [ ] I Added CHANGELOG entry regarding this change
  • [x] I have implemented unit tests to cover my changes
  • [ ] I have added/updated the javadocs and other documentation accordingly
  • [ ] No new bugs, code smells, etc. in SonarCloud report
  • [ ] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

sunix avatar Jun 09 '22 09:06 sunix

@sunix : Could you please resolve this minor conflict?

rohanKanojia avatar Jul 12 '22 09:07 rohanKanojia

@sunix : Could you please resolve this minor conflict?

Yes done, I have rebased

sunix avatar Jul 12 '22 14:07 sunix

TODO : try not to add additional dependencies

sunix avatar Nov 23 '22 10:11 sunix