kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Published 20 hours ago • verified publisher icon fabric8io

Initial version of GKE Auth support without gcloud

Open talatuyarer opened this issue 2 years ago • 8 comments

Description

I implement new a TokenRefresher for GKE based on Google documentation. This implementation does not need gcloud. Just need a service account and kubeconfig. Detail explaination you can check here

https://cloud.google.com/kubernetes-engine/docs/how-to/api-server-authentication

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [x] Code contributed by me aligns with current project license: Apache 2.0
  • [x] I Added CHANGELOG entry regarding this change
  • [x] I have implemented unit tests to cover my changes
  • [x] I have added/updated the javadocs and other documentation accordingly
  • [x] No new bugs, code smells, etc. in SonarCloud report
  • [x] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

talatuyarer avatar Jun 03 '22 08:06 talatuyarer

@manusa Could you take a look my pr ? I tested on GKE cluster. There is no issue. It works as expected.

talatuyarer avatar Jun 08 '22 06:06 talatuyarer

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

71.9% 71.9% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 08 '22 07:06 sonarqubecloud[bot]

@talatuyarer: polite ping, Are you still working on this?

rohanKanojia avatar Aug 24 '22 04:08 rohanKanojia

Hey @rohanKanojia Let me update my pr. We started using my implementation for older version of fabric8. I will send an update commit in this week.

talatuyarer avatar Aug 30 '22 00:08 talatuyarer

@talatuyarer : polite ping, Did you get some time to rebase your PR against latest version?

rohanKanojia avatar Sep 09 '22 05:09 rohanKanojia

Let's rebase and address the review comments with this after #4702

shawkins avatar Jan 11 '23 13:01 shawkins

I actually have rebased version with current master. I can push before https://github.com/fabric8io/kubernetes-client/pull/4702 @shawkins

In addition to this last month I implement AWS EKS support also.

talatuyarer avatar Jan 11 '23 20:01 talatuyarer

@talatuyarer: polite ping, Are you still working on this?

sunix avatar Jul 04 '23 08:07 sunix